Fix rounding inconsistencies when cropping#29
Open
boris-petrov wants to merge 2 commits intojnormington:masterfrom
Open
Fix rounding inconsistencies when cropping#29boris-petrov wants to merge 2 commits intojnormington:masterfrom
boris-petrov wants to merge 2 commits intojnormington:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jnormington Happy New Year! Both 2023 and 2024! 😄
I noticed that I'm getting some inconsistent screenshots sometimes which I guess depend on rounding inconsistencies when cropping. I try to fix this in this commit. Let me know what you think.
That could be released as a patch version.
P.S. I also no longer restrict the cropping to be "part" of the image - i.e. the numbers passed to
mini_magickfor cropping could be larger than the image itself. I think it handles that gracefully so no need for us to do it here.